linux-kernel - Re: [PATCH v5 1/2] dt-bindings: i2c: npcm7xx: * add binding for i2c controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a599e9e7-6b00-2bbc-407a-8f48b17b43c5@axentia.se>
Date:   Tue, 19 Nov 2019 22:30:19 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Tali Perry <tali.perry1@...il.com>,
        "avifishman70@...il.com" <avifishman70@...il.com>,
        "tmaimon77@...il.com" <tmaimon77@...il.com>,
        "venture@...gle.com" <venture@...gle.com>,
        "yuenn@...gle.com" <yuenn@...gle.com>,
        "benjaminfair@...gle.com" <benjaminfair@...gle.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "jdelvare@...e.de" <jdelvare@...e.de>,
        "jarkko.nikula@...ux.intel.com" <jarkko.nikula@...ux.intel.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "arnd@...db.de" <arnd@...db.de>, "max@...as.org" <max@...as.org>,
        "krzysztof.adamski@...ia.com" <krzysztof.adamski@...ia.com>,
        "syniurge@...il.com" <syniurge@...il.com>,
        "puwen@...on.cn" <puwen@...on.cn>,
        "jfi@...-embedded.de" <jfi@...-embedded.de>,
        "sr@...x.de" <sr@...x.de>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "kdasu.kdev@...il.com" <kdasu.kdev@...il.com>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "baolin.wang@...aro.org" <baolin.wang@...aro.org>,
        "ludovic.desroches@...rochip.com" <ludovic.desroches@...rochip.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: npcm7xx: * add binding for i2c
 controller

On 2019-11-19 15:49, Tali Perry wrote:
>  dt-bindings: i2c: npcm7xx: * add binding for i2c controller

I missing an empty line before the block of tags, but the bigger problem
is the repeated subject line. Also, the '*' in the subject makes no
sense to me.

> Signed-off-by: Tali Perry <tali.perry1@...il.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
>  .../devicetree/bindings/i2c/i2c-npcm7xx.txt   | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> new file mode 100644
> index 000000000000..0ecae950748b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
> @@ -0,0 +1,29 @@
> +Nuvoton NPCM7XX I2C bus
> +
> +The NPCM750x includes sixteen I2C bus controllers. All Controllers support
> +both master and slave mode. Each controller has two 16 byte HW FIFO for TX and
> +RX.
> +
> +Required properties:
> +- compatible      : must be "nuvoton,npcm750-i2c"
> +- reg             : Offset and length of the register set for the device.
> +- interrupts      : Contain the I2C interrupt with flags for falling edge.
> +- clocks          : phandle of I2C reference clock.
> +
> +Optional:
> +- bus-frequency   : Contain the I2C bus frequency,
> +			the default I2C bus frequency is 100000.
> +- pinctrl-0       : must be <&smbX_pins>, X is module number
> +			(on NPCM7XX it's 0 to 15)

Isn't this a strange requirement? Am I, as a device tree author, not free to
use any label names I want? Surely, what is important is what the label refers
to and not its name?

Cheers,
Peter

> +- pinctrl-names   : should be set to "default"
> +Example:
> +
> +	i2c0: i2c@...00 {
> +		compatible = "nuvoton,npcm750-i2c";
> +		reg = <0x80000 0x1000>;
> +		clocks = <&clk NPCM7XX_CLK_APB2>;
> +		bus-frequency = <100000>;
> +		interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&smb0_pins>;
> +	};
>