linux-kernel - Re: [net PATCH v2] taprio: don't reject same mqprio settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191119.153341.1849410731804008442.davem@davemloft.net>
Date:   Tue, 19 Nov 2019 15:33:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ivan.khoronzhuk@...aro.org
Cc:     netdev@...r.kernel.org, vinicius.gomes@...el.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us,
        linux-kernel@...r.kernel.org, olteanv@...il.com
Subject: Re: [net PATCH v2] taprio: don't reject same mqprio settings

From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Date: Tue, 19 Nov 2019 02:23:12 +0200

> The taprio qdisc allows to set mqprio setting but only once. In case
> if mqprio settings are provided next time the error is returned as
> it's not allowed to change traffic class mapping in-flignt and that
> is normal. But if configuration is absolutely the same - no need to
> return error. It allows to provide same command couple times,
> changing only base time for instance, or changing only scheds maps,
> but leaving mqprio setting w/o modification. It more corresponds the
> message: "Changing the traffic mapping of a running schedule is not
> supported", so reject mqprio if it's really changed.
> 
> Also corrected TC_BITMASK + 1 for consistency, as proposed.
> 
> Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> Tested-by: Vladimir Oltean <olteanv@...il.com>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Applied and queued up for -stable.