linux-kernel - Re: [PATCH][next] net: phy: dp83869: fix return of uninitialized variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191118.172358.1651088156867288729.davem@davemloft.net>
Date:   Mon, 18 Nov 2019 17:23:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        dmurphy@...com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: phy: dp83869: fix return of uninitialized
 variable ret

From: Colin King <colin.king@...onical.com>
Date: Mon, 18 Nov 2019 11:48:35 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> In the case where the call to phy_interface_is_rgmii returns zero
> the variable ret is left uninitialized and this is returned at
> the end of the function dp83869_configure_rgmii.  Fix this by
> returning 0 instead of the uninitialized value in ret.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.