linux-kernel - Re: [PATCH net-next] bnx2x: initialize ethtool info->fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191118.175818.1172073606217291260.davem@davemloft.net>
Date:   Mon, 18 Nov 2019 17:58:18 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jtoppins@...hat.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com, skalluru@...vell.com,
        GR-everest-linux-l2@...vell.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] bnx2x: initialize ethtool info->fw_version
 before use

From: Jonathan Toppins <jtoppins@...hat.com>
Date: Mon, 18 Nov 2019 12:07:53 -0500

>     probe begin { printf("net-info  version 01.01\n")}
> 
>     function memset(msg:long) %{
>     	memset((char*)STAP_ARG_msg,-1,196);
>     %}
> 
>     probe module("bnx2x").function("bnx2x_get_drvinfo")
>     {
>       printf("In function\n");
>       memset(register("rsi"));

This makes no sense.

This function is called with the buffer cleared to zero.

You're scrambling something to simulate a "bug", but that will never
be scrambled in reality.