[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1574150240.19262.7.camel@mtksdccf07>
Date: Tue, 19 Nov 2019 15:57:20 +0800
From: Sam Shih <sam.shih@...iatek.com>
To: Matthias Brugger <matthias.bgg@...il.com>
CC: Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
<devicetree@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support
On Sun, 2019-11-10 at 21:51 +0100, Matthias Brugger wrote:
>
> On 22/10/2019 15:30, Sam Shih wrote:
> > This adds pwm support for MT7629.
> > Used:
> > https://patchwork.kernel.org/patch/11160851/
> >
> > Signed-off-by: Sam Shih <sam.shih@...iatek.com>
> > ---
> > arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> > index 9608bc2ccb3f..24375fc5f936 100644
> > --- a/arch/arm/boot/dts/mt7629.dtsi
> > +++ b/arch/arm/boot/dts/mt7629.dtsi
> > @@ -241,6 +241,21 @@
> > status = "disabled";
> > };
> >
> > + pwm: pwm@...06000 {
> > + compatible = "mediatek,mt7629-pwm";
> > + reg = <0x11006000 0x1000>;
> > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> > + <&pericfg CLK_PERI_PWM_PD>,
> > + <&pericfg CLK_PERI_PWM1_PD>;
> > + clock-names = "top", "main", "pwm1";
> > + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> > + assigned-clock-parents =
> > + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> > + num-pwms = <1>;
>
> num-pwms is not defined. Did you mean pwm-cells?
>
> Regards,
> Matthias
>
> > + status = "disabled";
> > + };
> > +
> > i2c: i2c@...07000 {
> > compatible = "mediatek,mt7629-i2c",
> > "mediatek,mt2712-i2c";
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Sorry for the Late Reply,
The num-pwms field is redundant after we derive it from the compatible
string. I forgot to remove it from the device tree.
I will send a new version.
Thanks,
Best Regards,
Sam Shih
Powered by blists - more mailing lists