linux-kernel - Re: [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 18:33:43 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Baruch Siach <baruch@...s.co.il>,
        Stephen Brennan <stephen@...nnan.io>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Scott Branden <sbranden@...adcom.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ray Jui <rjui@...adcom.com>, linux-kernel@...r.kernel.org,
        Eric Anholt <eric@...olt.net>,
        Rob Herring <robh+dt@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com,
        Stefan Wahren <wahrenst@....net>,
        Matt Mackall <mpm@...enic.com>, Arnd Bergmann <arnd@...db.de>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711



On 20/11/2019 05:52, Baruch Siach wrote:
> Hi Stephen, Stefan,
> 
> On Wed, Nov 20 2019, Stephen Brennan wrote:
>> From: Stefan Wahren <wahrenst@....net>
>>
>> BCM2711 features a RNG200 hardware random number generator block.
>> So make the driver available.
>>
>> Signed-off-by: Stefan Wahren <wahrenst@....net>
>> Signed-off-by: Stephen Brennan <stephen@...nnan.io>
>> Reviewed-by: Matthias Brugger <mbrugger@...e.com>
>> ---
>>  drivers/char/hw_random/Kconfig        | 2 +-
>>  drivers/char/hw_random/iproc-rng200.c | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
>> index 7c7fecfa2fb2..77e848fca531 100644
>> --- a/drivers/char/hw_random/Kconfig
>> +++ b/drivers/char/hw_random/Kconfig
>> @@ -90,7 +90,7 @@ config HW_RANDOM_BCM2835
>>  
>>  config HW_RANDOM_IPROC_RNG200
>>  	tristate "Broadcom iProc/STB RNG200 support"
>> -	depends on ARCH_BCM_IPROC || ARCH_BRCMSTB
>> +	depends on ARCH_BCM_IPROC || ARCH_BCM2835 || ARCH_BRCMSTB
>>  	default HW_RANDOM
>>  	---help---
>>  	  This driver provides kernel-side support for the RNG200
>> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
>> index 899ff25f4f28..32d9fe61a225 100644
>> --- a/drivers/char/hw_random/iproc-rng200.c
>> +++ b/drivers/char/hw_random/iproc-rng200.c
>> @@ -213,6 +213,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
>>  }
>>  
>>  static const struct of_device_id iproc_rng200_of_match[] = {
>> +	{ .compatible = "brcm,bcm2711-rng200", },
>>  	{ .compatible = "brcm,bcm7211-rng200", },
> 
> Again, duplicate of commit 1fa6d053b2a5.
> 

That commit adds 7211 compatible while this patch adds one for 2711.

Regards,
Matthias