linux-kernel - RE: [PATCH] misc: xilinx_sdfec: fix xsdfec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 19:08:49 +0000
From:   Dragan Cvetic <draganc@...inx.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Derek Kiernan <dkiernan@...inx.com>
Subject: RE: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type

Hi Luc,

Thanks for the really useful answer.

I promise I'll test this soon.

Thanks
Dragan


> -----Original Message-----
> From: Luc Van Oostenryck [mailto:luc.vanoostenryck@...il.com]
> Sent: Wednesday 20 November 2019 18:02
> To: Dragan Cvetic <draganc@...inx.com>
> Cc: linux-kernel@...r.kernel.org; Derek Kiernan <dkiernan@...inx.com>
> Subject: Re: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type
> 
> On Wed, Nov 20, 2019 at 03:59:24PM +0000, Dragan Cvetic wrote:
> > Hi Luc,
> >
> > For the sake of my understanding I'd like to ask you when the .pole method is defined
> > Why I'm asking this? I have a fairly new book (published in 2017) which suggests what is implemented in SDFEC driver.
> >
> > I'll test your suggestions and will come back to you soon.
> 
> Well, yes, it changed in July 2017.
> 
> The current definition can be found in include/linux/fs.h:
> 	struct file_operations {
> 		...
> 		__poll_t (*poll) (struct file *, struct poll_table_struct *);
> 		...
> 
> The main commit making the change is:
>     a3f8683bf7d5 ("->poll() methods should return __poll_t")
> 
> 
> The result can be verified by compiling the driver with the command
> 	make C=2 path/to/the/driver.o
> which will use the static analyser 'sparse' to make additional checks
> where the difference between 'unsigned int' and __poll_t will matter.
> See Documentation/dev-tools/sparse.rst for more info about it.
> 
> Best regards,
> -- Luc Van Oostenryck