linux-kernel - Re: [PATCH 2/2] mfd: ab8500-core: Add device tree support for AB8505

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYx1SP4r48L+5vJMttuGPoRH+HMhBw-CnZN0MdqtwZdVg@mail.gmail.com>
Date:   Wed, 20 Nov 2019 21:17:26 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] mfd: ab8500-core: Add device tree support for AB8505

On Sun, Nov 17, 2019 at 11:14 PM Stephan Gerhold <stephan@...hold.net> wrote:

> AB8505 support was never fully converted to the device tree.
> Most of the MFD cells for AB8505 lack an "of_compatible",
> which prevents them from being configured through the device tree.
>
> Align the definition of the AB8505 MFD cells with the ones for AB8500,
> and add device tree compatibles. Except for GPIO and regulators the
> compatibles are equal to those used for AB8500 because the hardware
> does not differ much.
>
> Finally, change db8500_prcmu_register_ab8500() to check for the AB8505
> device tree node additionally, and probe it if it is found.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij