linux-kernel - Re: [PATCH v3 2/3] leds: tps6105x: add driver for mfd chip led mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiXP8xu3UQTZxEqSXNkic3iNU43hD-KBJQkAmduXPp8zhQ@mail.gmail.com>
Date:   Wed, 20 Nov 2019 16:41:51 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Grigoryev Denis <grigoryev@...twel.ru>,
        Axel Lin <axel.lin@...ics.com>, Dan Murphy <dmurphy@...com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v3 2/3] leds: tps6105x: add driver for mfd chip led mode

Hi Jacek,

On Wed, Nov 20, 2019 at 4:33 PM Jacek Anaszewski
<jacek.anaszewski@...il.com> wrote:
> This is covered in DT bindings, it is redundant in the commit message.

Ok, I will remove it from the commit message.

> > +     priv->cdev.name = "tps6105x::torch";
>
> Please remove above line.
>
> And use new LED registration API like below:
>
> struct led_init_data init_data = {
>         .devicename = "tps6105x",
>         .default_label = ":torch" };
>
> return devm_led_classdev_register_ext(&pdev->dev, &priv->cdev, &init_data);

I would love to do that, but my platform (with a tps6105x) can only boot a lts
vendor kernel (4.14). classdev_register_ext() is not available there.

I can make the change you suggest, but cannot test to check if it will actually
work. Is that ok for you?