linux-kernel - Re: [PATCH 4.19 038/422] soundwire: Initialize completion for defer messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120215417.GA23361@duo.ucw.cz>
Date:   Wed, 20 Nov 2019 22:54:17 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Vinod Koul <vkoul@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 038/422] soundwire: Initialize completion for defer
 messages

On Tue 2019-11-19 06:13:55, Greg Kroah-Hartman wrote:
> From: Shreyas NC <shreyas.nc@...el.com>
> 
> [ Upstream commit a306a0e4a5326269b6c78d136407f08433ab5ece ]
> 
> Deferred messages are async messages used to synchronize
> transitions mostly while doing a bank switch on multi links.
> On successful transitions these messages are marked complete
> and thereby confirming that all the buses performed bank switch
> successfully.
> 
> So, initialize the completion structure for the same.
> 
> Signed-off-by: Sanyog Kale <sanyog.r.kale@...el.com>

This is only called from sdw_transfer_defer() and that function is
called in mainline, but is unused in 4.19.X.

So I don't think this is suitable for -stable.

Best regards,
								Pavel

> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 83576810eee65..df172bf3925f6 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -175,6 +175,7 @@ static inline int do_transfer_defer(struct sdw_bus *bus,
>  
>  	defer->msg = msg;
>  	defer->length = msg->len;
> +	init_completion(&defer->complete);
>  
>  	for (i = 0; i <= retry; i++) {
>  		resp = bus->ops->xfer_msg_defer(bus, msg, defer);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)