linux-kernel - Re: [x86/iopl PATCH] x86/ioperm: Fix use of deprecated config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1911202333190.29534@nanos.tec.linutronix.de>
Date:   Wed, 20 Nov 2019 23:34:10 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Alexander Duyck <alexander.duyck@...il.com>
cc:     linux-kernel@...r.kernel.org, bp@...en8.de, mingo@...nel.org,
        luto@...nel.org
Subject: Re: [x86/iopl PATCH] x86/ioperm: Fix use of deprecated config
 option

On Wed, 20 Nov 2019, Alexander Duyck wrote:
> From: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> 
> Fixes: 111e7b15cf10 ("x86/ioperm: Extend IOPL config to control ioperm() as well")
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>

Duh, yes. 

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

> ---
>  arch/x86/kernel/process.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 7964d7db9366..bd2a11ca5dd6 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -382,8 +382,7 @@ void tss_update_io_bitmap(void)
>  	if (test_thread_flag(TIF_IO_BITMAP)) {
>  		struct thread_struct *t = &current->thread;
>  
> -		if (IS_ENABLED(CONFIG_X86_IOPL_EMULATION) &&
> -		    t->iopl_emul == 3) {
> +		if (IS_ENABLED(CONFIG_X86_IOPL_IOPERM) && t->iopl_emul == 3) {
>  			*base = IO_BITMAP_OFFSET_VALID_ALL;
>  		} else {
>  			struct io_bitmap *iobm = t->io_bitmap;
> 
>