linux-kernel - Re: [PATCH 4.19 038/422] soundwire: Initialize completion for defer messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96ef8f59-e0f1-ed87-d712-13d5419f9068@linux.intel.com>
Date:   Wed, 20 Nov 2019 16:52:06 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>,
        Vinod Koul <vkoul@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 038/422] soundwire: Initialize completion for defer
 messages


>> [ Upstream commit a306a0e4a5326269b6c78d136407f08433ab5ece ]
>>
>> Deferred messages are async messages used to synchronize
>> transitions mostly while doing a bank switch on multi links.
>> On successful transitions these messages are marked complete
>> and thereby confirming that all the buses performed bank switch
>> successfully.
>>
>> So, initialize the completion structure for the same.
>>
>> Signed-off-by: Sanyog Kale <sanyog.r.kale@...el.com>
> 
> This is only called from sdw_transfer_defer() and that function is
> called in mainline, but is unused in 4.19.X.
> 
> So I don't think this is suitable for -stable.

Agree.

Multi-link solutions with synchronized streaming are not supported just 
yet. It's an important feature but it'll only be enabled after the 
existing backlog of 60+ patches are merged, and when the ASoC multi-cpu 
support allows for this feature, hopefully for 5.7.

my 2 cents
-Pierre