linux-kernel - Re: [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BYKH0ACN38Y1.2TRTJUY5267L4@pride>
Date:   Tue, 19 Nov 2019 21:21:49 -0800
From:   "Stephen Brennan" <stephen@...nnan.io>
To:     "Baruch Siach" <baruch@...s.co.il>,
        <linux-arm-kernel@...ts.infradead.org>
Cc:     <stephen@...nnan.io>, "Mark Rutland" <mark.rutland@....com>,
        <devicetree@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Herbert Xu" <herbert@...dor.apana.org.au>,
        "Scott Branden" <sbranden@...adcom.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Ray Jui" <rjui@...adcom.com>, <linux-kernel@...r.kernel.org>,
        "Eric Anholt" <eric@...olt.net>,
        "Rob Herring" <robh+dt@...nel.org>,
        <bcm-kernel-feedback-list@...adcom.com>,
        "Stefan Wahren" <wahrenst@....net>,
        "Matt Mackall" <mpm@...enic.com>, "Arnd Bergmann" <arnd@...db.de>,
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible

Hi Baruch,

On Wed Nov 20, 2019 at 6:50 AM, Baruch Siach wrote:
> Hi Stephen, Stefan,
>
> 
> On Wed, Nov 20 2019, Stephen Brennan wrote:
>
> 
> > From: Stefan Wahren <wahrenst@....net>
> >
> > The BCM2711 has a RNG200 block, so document its compatible string.
> >
> > Signed-off-by: Stefan Wahren <wahrenst@....net>
> > Signed-off-by: Stephen Brennan <stephen@...nnan.io>
>
> 
> Isn't that duplicate of Florian's commit 6223949a1531?
>
> 
> > ---
> >  Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > index c223e54452da..802523196ee5 100644
> > --- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > +++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > @@ -2,6 +2,7 @@ HWRNG support for the iproc-rng200 driver
> >  
> >  Required properties:
> >  - compatible : Must be one of:
> > +	       "brcm,bcm2711-rng200"
> >  	       "brcm,bcm7211-rng200"
>
> 
> Isn't this clear text duplication? Am I missing something obvious?
>

I understand the confusion, but they're different, we're looking at the 
difference between:

   bcm2711
   bcm7211
      ^^

These are apparently separate but related chips, leading to confusion in 
other places [1] as well. I double checked the commit 6223949a1531 you 
pointed out, as well as 1fa6d053b2a5 from your other email, to verify that 
this is the case. No duplication (as far as I can tell) is in the series.

[1]: https://github.com/raspberrypi/linux/issues/3163

Regards,
Stephen

> 
> I was looking at versions of this patch series wondering why no one
> noticed that.
>
> 
> baruch
>
> 
> >  	       "brcm,bcm7278-rng200"
> >  	       "brcm,iproc-rng200"
>
> 
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>
> 
>
>