linux-kernel - Re: [PATCH 07/12] crypto: caam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 06:48:46 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Tom Lendacky <thomas.lendacky@....com>,
        Gary Hook <gary.hook@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 07/12] crypto: caam - refactor caam_jr_enqueue

On 11/20/2019 12:49 AM, Iuliana Prodan wrote:
> On 11/19/2019 7:55 PM, Horia Geanta wrote:
>> On 11/18/2019 12:31 AM, Iuliana Prodan wrote:
>>> diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c
>>> index baf4ab1..d9de3dc 100644
>>> --- a/drivers/crypto/caam/caamhash.c
>>> +++ b/drivers/crypto/caam/caamhash.c
>> [...]
>>> @@ -933,11 +943,13 @@ static int ahash_final_ctx(struct ahash_request *req)
>>>   			     DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
>>>   			     1);
>>>   
>>> -	ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, req);
>>> +	jrentry = &edesc->jrentry;
>>> +
>>> +	ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, jrentry);
>>>   	if (ret == -EINPROGRESS)
>>>   		return ret;
>>>   
>>> - unmap_ctx:
>>> +unmap_ctx:
>> That's correct, however whitespace fixing should be done separately.
>>
> Should I make a separate patch for these two whitespaces?
> 
Whitespace fixes should be moved out of this patch set.
In general, patches handling this go through the whole file / driver.

Horia