linux-kernel - Re: [PATCH 1/5] crypto: caam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB34852B194D4CB5051732AD41984F0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Date:   Wed, 20 Nov 2019 07:06:09 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
CC:     Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@....com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] crypto: caam - use static initialization

On 11/5/2019 5:14 PM, Andrey Smirnov wrote:
> @@ -589,8 +592,6 @@ static struct platform_driver caam_jr_driver = {
>  
>  static int __init jr_driver_init(void)
>  {
> -	spin_lock_init(&driver_data.jr_alloc_lock);
> -	INIT_LIST_HEAD(&driver_data.jr_list);
>  	return platform_driver_register(&caam_jr_driver);
>  }
>  
And with this change, jr_driver_{init,exit} could be replaced with
	module_platform_driver(caam_jr_driver);

It's probably worth adding this here even if we later decide
that moving away from platform driver for jr is the way to go.

Horia