[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87o8x7dlyb.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me>
Date: Wed, 20 Nov 2019 09:51:56 +0200
From: Adrian Ratiu <adrian.ratiu@...labora.com>
To: Fabio Estevam <festevam@...il.com>,
Adrian Ratiu <adrian.ratiu@...labora.com>
Cc: "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Martyn Welch <martyn.welch@...labora.com>,
Sjoerd Simons <sjoerd.simons@...labora.com>,
linux-kernel <linux-kernel@...r.kernel.org>,
DRI mailing list <dri-devel@...ts.freedesktop.org>,
linux-rockchip@...ts.infradead.org,
NXP Linux Team <linux-imx@....com>, kernel@...labora.com,
linux-stm32@...md-mailman.stormreply.com,
"moderated list\:ARM\/FREESCALE IMX \/ MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
Emil Velikov <emil.velikov@...labora.com>
Subject: Re: [PATCH v3 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver
On Tue, 19 Nov 2019, Fabio Estevam <festevam@...il.com> wrote:
> Hi Adrian,
Hi Fabio,
>
> On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu
> <adrian.ratiu@...labora.com> wrote:
>
> Some nitpicks:
>
>> + +config DRM_IMX_MIPI_DSI + tristate "Freescale i.MX DRM
>> MIPI DSI"
>
> This text seems too generic as there are i.MX SoCs that use
> different MIPI DSI IP.
>
> Maybe "Freescale i.MX6 DRM MIPI DSI" instead?
Yes, this is a good idea, will update in a newer version to make
it more specific. I'll let this version sit a little more on
review so others also have time to review.
Thank you!
>
>> +module_platform_driver(imx_mipi_dsi_driver); +
>> +MODULE_DESCRIPTION("i.MX MIPI DSI host controller driver");
>
> i.MX6 MIPI DSI, please.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Powered by blists - more mailing lists