linux-kernel - RE: [PATCH v3 10/13] exfat: add nls operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 18:02:10 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Markus Elfring'" <Markus.Elfring@....de>
Cc:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        "'Christoph Hellwig'" <hch@....de>,
        "'Daniel Wagner'" <dwagner@...e.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        'Valdis Klētnieks' <valdis.kletnieks@...edu>,
        <linkinjeon@...il.com>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v3 10/13] exfat: add nls operations

> …
> > +++ b/fs/exfat/nls.c
> …
> > +static int exfat_load_upcase_table(struct super_block *sb,
> > +		sector_t sector, unsigned long long num_sectors,
> > +		unsigned int utbl_checksum)
> > +{
> …
> > +error:
> > +	if (bh)
> > +		brelse(bh);
> 
> I am informed in the way that this function tolerates the passing
> of null pointers.
> https://protect2.fireeye.com/url?k=58476862-058969b1-5846e32d-000babff317b-
> 2bdcc1db1dc57528&u=https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/
> linux.git/tree/include/linux/buffer_head.h?id=af42d3466bdc8f39806b26f593604f
> dc54140bcb#n292
> https://protect2.fireeye.com/url?k=625424d5-3f9a2506-6255af9a-000babff317b-
> a544a35424b18c18&u=https://elixir.bootlin.com/linux/v5.4-
> rc8/source/include/linux/buffer_head.h#L292
> 
> Thus I suggest to omit the extra pointer check also at similar places.
> 
> Can the label “release_bh” be more helpful?
Hi Markus,

I checked not only review point but also your review points in
other patches, I will fix them on v4.

Thanks for your review!
> 
> Regards,
> Markus