linux-kernel - Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191120100345.038dd232@xps13>
Date:   Wed, 20 Nov 2019 10:03:45 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Richard Weinberger <richard@....at>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Jiri Slaby <jslaby@...e.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix
 build warning

Hi Greg,

Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote on Mon, 18 Nov
2019 20:40:10 +0100:

> On Mon, Nov 18, 2019 at 08:31:44PM +0100, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----  
> > > Von: "Miquel Raynal" <miquel.raynal@...tlin.com>
> > > An: "richard" <richard@....at>
> > > CC: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Sudip Mukherjee" <sudipm.mukherjee@...il.com>, "Kyungmin Park"
> > > <kyungmin.park@...sung.com>, "Vignesh Raghavendra" <vigneshr@...com>, "Jiri Slaby" <jslaby@...e.com>, "linux-kernel"
> > > <linux-kernel@...r.kernel.org>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-serial"
> > > <linux-serial@...r.kernel.org>
> > > Gesendet: Montag, 18. November 2019 20:22:57
> > > Betreff: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning  
> >   
> > > Hi all,
> > > 
> > > Richard Weinberger <richard@....at> wrote on Mon, 18 Nov 2019 13:47:50
> > > +0100 (CET):
> > >   
> > >> ----- Ursprüngliche Mail -----  
> > >> >> I was not sure if this should have been two different patch, but since
> > >> >> this will be fixing the same problem so it seems its better to have them
> > >> >> in a single patch.
> > >> >> 
> > >> >>  drivers/mtd/nand/onenand/Makefile                     | 2 +-
> > >> >>  drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> > >> >>  drivers/tty/serial/Makefile                           | 2 +-
> > >> >>  drivers/tty/serial/{samsung.c => samsung_tty.c}       | 0
> > >> >>  4 files changed, 2 insertions(+), 2 deletions(-)
> > >> >>  rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> > >> >>  rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)  
> > >> > 
> > >> > I can take this in the tty tree if the mtd maintainer gives an ack for
> > >> > it...  
> > >> 
> > >> Acked-by: Richard Weinberger <richard@....at>  
> > > 
> > > If it is not too late, I am not a big fan of the new naming which is
> > > rather not descriptive. Files in the onenand subdirectory are:
> > > * onenand_<something>.c for the base files
> > > * <vendor>.c for the vendors files (currently: omap2.c and samsung.c).  
> > 
> > Well, I'm fine with the naming either way. :-)  
> 
> If you want to rename the mtd driver later, that's fine, I'll take this
> for now for 5.5-rc1 and you all can bikeshed it for 5.5-final :)

Let's not rename it twice, if nobody want's another naming I'm fine
with this one.

Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>

Cheers!
Miquèl