linux-kernel - Re: [PATCH net v2] net: dsa: ocelot: add dependency for NET_DSA_MSCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9d6100-6965-da85-c310-6e1a9318f61d@huawei.com>
Date:   Wed, 20 Nov 2019 17:38:38 +0800
From:   maowenan <maowenan@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <vladimir.oltean@....com>, <claudiu.manoil@....com>,
        <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net v2] net: dsa: ocelot: add dependency for
 NET_DSA_MSCC_FELIX



在 2019/11/20 10:53, David Miller 写道:
> From: Mao Wenan <maowenan@...wei.com>
> Date: Wed, 20 Nov 2019 09:47:22 +0800
> 
>> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
>> below errors can be found:
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
>> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
>> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
>>
>> and warning as below:
>> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
>> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
>> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
>> Selected by [y]:
>> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
>> && NET_DSA [=y] && PCI [=y]
>>
>> This patch is to select NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.
>>
>> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
>> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> 
> You did not read my feedback, read it again please.
Sorry for that, do you mean firstly to resolve dependencies according to MSCC_OCELOT_SWITCH,
config MSCC_OCELOT_SWITCH
        tristate "Ocelot switch driver"
        depends on NET_SWITCHDEV
        depends on HAS_IOMEM

after that to select in MSCC_OCELOT_SWITCH in NET_DSA_MSCC_FELIX,
config NET_DSA_MSCC_FELIX
        tristate "Ocelot / Felix Ethernet switch support"
        depends on NET_DSA && PCI
+	select NET_VENDOR_MICROSEMI
+       depends on NET_SWITCHDEV
+	depends on HAS_IOMEM
        select MSCC_OCELOT_SWITCH
        select NET_DSA_TAG_OCELOT
        help


> 
> .
>