[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87lfsac01k.fsf@mpe.ellerman.id.au>
Date: Wed, 20 Nov 2019 21:30:31 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Dan Williams <dan.j.williams@...el.com>, linux-nvdimm@...ts.01.org
Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Oliver O'Halloran <oohall@...il.com>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
peterz@...radead.org, vishal.l.verma@...el.com,
dave.hansen@...ux.intel.com, hch@....de,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 16/18] powerpc/papr_scm: Switch to numa_map_to_online_node()
Dan Williams <dan.j.williams@...el.com> writes:
> Now that the core exports numa_map_to_online_node() switch to that
> instead of the locally coded duplicate.
>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
Acked-by: Michael Ellerman <mpe@...erman.id.au>
cheers
> Cc: "Oliver O'Halloran" <oohall@...il.com>
> Reported-by: "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
> arch/powerpc/platforms/pseries/papr_scm.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index 33aa59e666e5..ef81515f3b6a 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -284,25 +284,6 @@ int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
> return 0;
> }
>
> -static inline int papr_scm_node(int node)
> -{
> - int min_dist = INT_MAX, dist;
> - int nid, min_node;
> -
> - if ((node == NUMA_NO_NODE) || node_online(node))
> - return node;
> -
> - min_node = first_online_node;
> - for_each_online_node(nid) {
> - dist = node_distance(node, nid);
> - if (dist < min_dist) {
> - min_dist = dist;
> - min_node = nid;
> - }
> - }
> - return min_node;
> -}
> -
> static int papr_scm_nvdimm_init(struct papr_scm_priv *p)
> {
> struct device *dev = &p->pdev->dev;
> @@ -347,7 +328,7 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p)
>
> memset(&ndr_desc, 0, sizeof(ndr_desc));
> target_nid = dev_to_node(&p->pdev->dev);
> - online_nid = papr_scm_node(target_nid);
> + online_nid = numa_map_to_online_node(target_nid);
> ndr_desc.numa_node = online_nid;
> ndr_desc.target_node = target_nid;
> ndr_desc.res = &p->res;
Powered by blists - more mailing lists