linux-kernel - Re: [PATCH v2] fork: fix pidfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191120105227.uln6z5d67ita3edj@wittgenstein>
Date:   Wed, 20 Nov 2019 11:52:29 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH v2] fork: fix pidfd_poll()'s return type

On Wed, Nov 20, 2019 at 01:33:20AM +0100, Luc Van Oostenryck wrote:
> pidfd_poll() is defined as returning 'unsigned int' but the
> .poll method is declared as returning '__poll_t', a bitwise type.
> 
> Fix this by using the proper return type and using the EPOLL
> constants instead of the POLL ones, as required for __poll_t.
> 
> Fixes: b53b0b9d9a61 ("pidfd: add polling support")
> Cc: Joel Fernandes (Google) <joel@...lfernandes.org>
> Cc: Christian Brauner <christian@...uner.io>
> Cc: stable@...r.kernel.org # 5.3
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> Reviewed-by: Christian Brauner <christian.brauner@...ntu.com>

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fixes

Will likely send this as a fix for v5.4 still so stable only has to
backport this to 5.3 and not 5.4 too.

Thanks!
Christian