linux-kernel - Re: [PATCH] arm: Fix topology setup in case of CPU hotplug for CONFIG_SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5f99e82-0640-72e6-2499-16e99b1aeae0@arm.com>
Date:   Wed, 20 Nov 2019 12:30:11 +0000
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     Atish Patra <atish.patra@....com>,
        Russell King <linux@...linux.org.uk>,
        Morten Rasmussen <morten.rasmussen@....com>,
        Lukasz Luba <lukasz.luba@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: Fix topology setup in case of CPU hotplug for
 CONFIG_SCHED_MC

On 20.11.19 11:09, Sudeep Holla wrote:
> Hi Dietmar, Lukasz,
> 
> Thanks for digging this bug and fixing it.
> 
> On Wed, Nov 20, 2019 at 10:42:12AM +0000, Dietmar Eggemann wrote:

[...]

>> @@ -231,14 +230,14 @@ void store_cpu_topology(unsigned int cpuid)
>>  		cpuid_topo->package_id = -1;
>>  	}
>>
>> -	update_siblings_masks(cpuid);
>> -
>>  	update_cpu_capacity(cpuid);
>>
>>  	pr_info("CPU%u: thread %d, cpu %d, socket %d, mpidr %x\n",
>> -		cpuid, cpu_topology[cpuid].thread_id,
>> -		cpu_topology[cpuid].core_id,
>> -		cpu_topology[cpuid].package_id, mpidr);
>> +		cpuid, cpuid_topo->thread_id, cpuid_topo->core_id,
>> +		cpuid_topo->package_id, mpidr);
>> +
> 
> [nit] The above is a clearly cosmetic cleanup and shouldn't be part of
> this fix as they will be backported automatically. So I prefer to drop
> this or make it separate patch if required.

I can get rid of this cleanup in v2. Thanks for the review!