linux-kernel - Re: [PATCH 4.19 352/422] slimbus: ngd: register ngd driver only once.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120123113.GD4495@amd>
Date:   Wed, 20 Nov 2019 13:31:13 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 352/422] slimbus: ngd: register ngd driver only once.

On Tue 2019-11-19 06:19:09, Greg Kroah-Hartman wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> [ Upstream commit 1830dad34c070161fda2ff1db77b39ffa78aa380 ]
> 
> Move ngd platform driver out of loop so that it registers only once.

AFAICT driver_register is immediately followed by "return", so it was
already registered only once before you patched it.

I don't think this should be in stable.

Best regards,
								Pavel

> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1346,7 +1346,6 @@ static int of_qcom_slim_ngd_register(struct device *parent,
>  		ngd->base = ctrl->base + ngd->id * data->offset +
>  					(ngd->id - 1) * data->size;
>  		ctrl->ngd = ngd;
> -		platform_driver_register(&qcom_slim_ngd_driver);
>  
>  		return 0;
>  	}
> @@ -1445,6 +1444,7 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
>  	init_completion(&ctrl->reconf);
>  	init_completion(&ctrl->qmi.qmi_comp);
>  
> +	platform_driver_register(&qcom_slim_ngd_driver);
>  	return of_qcom_slim_ngd_register(dev, ctrl);
>  }
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)