linux-kernel - Re: [GIT PULL 1/3] intel_th: Fix a double put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sgmid5ml.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Wed, 20 Nov 2019 15:44:34 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Wen Yang <wenyang@...ux.alibaba.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        stable@...r.kernel.org, alexander.shishkin@...ux.intel.com
Subject: Re: [GIT PULL 1/3] intel_th: Fix a double put_device() in error path

Wen Yang <wenyang@...ux.alibaba.com> writes:

> device_add() has increased the reference count,
>
> so when it returns an error, an additional call to put_device()
>
> is needed here to reduce the reference count.

No, in case of error it also drops its reference.

Regards,
--
Alex