linux-kernel - Re: [PATCH] mm: Fix Kconfig indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 15:36:44 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Fix Kconfig indentation

On 20.11.19 14:37, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> 	$ sed -e 's/^        /\t/' -i */Kconfig
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>   mm/Kconfig | 28 ++++++++++++++--------------
>   1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e38ff1d5968d..27b7e61e3055 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -160,9 +160,9 @@ config MEMORY_HOTPLUG_SPARSE
>   	depends on SPARSEMEM && MEMORY_HOTPLUG
>   
>   config MEMORY_HOTPLUG_DEFAULT_ONLINE
> -        bool "Online the newly added memory blocks by default"
> -        depends on MEMORY_HOTPLUG
> -        help
> +	bool "Online the newly added memory blocks by default"
> +	depends on MEMORY_HOTPLUG
> +	help
>   	  This option sets the default policy setting for memory hotplug
>   	  onlining policy (/sys/devices/system/memory/auto_online_blocks) which
>   	  determines what happens to newly added memory regions. Policy setting
> @@ -227,14 +227,14 @@ config COMPACTION
>   	select MIGRATION
>   	depends on MMU
>   	help
> -          Compaction is the only memory management component to form
> -          high order (larger physically contiguous) memory blocks
> -          reliably. The page allocator relies on compaction heavily and
> -          the lack of the feature can lead to unexpected OOM killer
> -          invocations for high order memory requests. You shouldn't
> -          disable this option unless there really is a strong reason for
> -          it and then we would be really interested to hear about that at
> -          linux-mm@...ck.org.
> +	  Compaction is the only memory management component to form
> +	  high order (larger physically contiguous) memory blocks
> +	  reliably. The page allocator relies on compaction heavily and
> +	  the lack of the feature can lead to unexpected OOM killer
> +	  invocations for high order memory requests. You shouldn't
> +	  disable this option unless there really is a strong reason for
> +	  it and then we would be really interested to hear about that at
> +	  linux-mm@...ck.org.
>   
>   #
>   # support for page migration
> @@ -302,10 +302,10 @@ config KSM
>   	  root has set /sys/kernel/mm/ksm/run to 1 (if CONFIG_SYSFS is set).
>   
>   config DEFAULT_MMAP_MIN_ADDR
> -        int "Low address space to protect from user allocation"
> +	int "Low address space to protect from user allocation"
>   	depends on MMU
> -        default 4096
> -        help
> +	default 4096
> +	help
>   	  This is the portion of low virtual memory which should be protected
>   	  from userspace allocation.  Keeping a user from writing to low pages
>   	  can help reduce the impact of kernel NULL pointer bugs.
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb