linux-kernel - Re: [PATCH] mdio_bus: Fix init if CONFIG_RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191119.191803.1036643221927656820.davem@davemloft.net>
Date:   Tue, 19 Nov 2019 19:18:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     f.fainelli@...il.com, geert+renesas@...der.be,
        yuehaibing@...wei.com, andrew@...n.ch, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mdio_bus: Fix init if CONFIG_RESET_CONTROLLER=n

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Tue, 19 Nov 2019 19:55:53 +0100

> Hi Florian,
> 
> On Tue, Nov 19, 2019 at 7:05 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>> On 11/19/19 3:25 AM, Geert Uytterhoeven wrote:
>> > Commit 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after
>> > initialization to constant") accidentally changed a check from -ENOTSUPP
>> > to -ENOSYS, causing failures if reset controller support is not enabled.
>> > E.g. on r7s72100/rskrza1:
>> >
>> >     sh-eth e8203000.ethernet: MDIO init failed: -524
>> >     sh-eth: probe of e8203000.ethernet failed with error -524
>> >
>> > Fixes: 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after initialization to constant")
>> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>>
>> This has been fixed in the "net" tree with:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=075e238d12c21c8bde700d21fb48be7a3aa80194
> 
> Ah, hadn't seen that one.
> 
> However, that one (a) keeps the unneeded check for -ENOSYS, and (b)
> carries a wrong Fixes tag.

Linus took Geert's fix so I reverted the one in 'net' and cherry picked
Geert's fix from Linus's tree.

Just FYI...