linux-kernel - Re: [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0101016e86f531d4-89c752f8-a9af-43fe-94b3-44121a1e057e-000000@us-west-2.amazonses.com>
Date:   Wed, 20 Nov 2019 03:57:26 +0000
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Sibi Sankar <sibis@...eaurora.org>, bjorn.andersson@...aro.org,
        robh+dt@...nel.org, ulf.hansson@...aro.org
Cc:     agross@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        mark.rutland@....com, swboyd@...omium.org, dianders@...omium.org
Subject: Re: [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings
 for SM8150


On 11/18/2019 11:10 PM, Sibi Sankar wrote:
> Add RPMH power-domain bindings for the SM8150 family of SoCs.
> 
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
> ---
>   .../devicetree/bindings/power/qcom,rpmpd.txt       |  1 +
>   include/dt-bindings/power/qcom-rpmpd.h             | 14 ++++++++++++++
>   2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
> index bc75bf49cdaea..f3bbaa4aef297 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt
> @@ -10,6 +10,7 @@ Required Properties:
>   	* qcom,msm8998-rpmpd: RPM Power domain for the msm8998 family of SoC
>   	* qcom,qcs404-rpmpd: RPM Power domain for the qcs404 family of SoC
>   	* qcom,sdm845-rpmhpd: RPMh Power domain for the sdm845 family of SoC
> +	* qcom,sm8150-rpmhpd: RPMh Power domain for the sm8150 family of SoC
>    - #power-domain-cells: number of cells in Power domain specifier
>   	must be 1.
>    - operating-points-v2: Phandle to the OPP table for the Power domain.
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index f05f8b1808ec9..7d43bafc0026b 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -15,12 +15,26 @@
>   #define SDM845_GFX	7
>   #define SDM845_MSS	8
>   
> +/* SM8150 Power Domain Indexes */
> +#define SM8150_MSS	0
> +#define SM8150_EBI	1
> +#define SM8150_LMX	2
> +#define SM8150_LCX	3
> +#define SM8150_GFX	4
> +#define SM8150_MX	5
> +#define SM8150_MX_AO	6
> +#define SM8150_CX	7
> +#define SM8150_CX_AO	8
> +#define SM8150_MMCX	9
> +#define SM8150_MMCX_AO	10
> +
>   /* SDM845 Power Domain performance levels */

You could perhaps remove this comment, or remove the
SDM845 from it.

Reviewed-by: Rajendra Nayak <rnayak@...eaurora.org>

>   #define RPMH_REGULATOR_LEVEL_RETENTION	16
>   #define RPMH_REGULATOR_LEVEL_MIN_SVS	48
>   #define RPMH_REGULATOR_LEVEL_LOW_SVS	64
>   #define RPMH_REGULATOR_LEVEL_SVS	128
>   #define RPMH_REGULATOR_LEVEL_SVS_L1	192
> +#define RPMH_REGULATOR_LEVEL_SVS_L2	224
>   #define RPMH_REGULATOR_LEVEL_NOM	256
>   #define RPMH_REGULATOR_LEVEL_NOM_L1	320
>   #define RPMH_REGULATOR_LEVEL_NOM_L2	336
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation