linux-kernel - Re: [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d4c340d-7b4f-6efe-7643-97f848fa1f04@collabora.com>
Date:   Wed, 20 Nov 2019 17:22:58 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Benson Leung <bleung@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_usbpd_logger: add missed
 destroy_workqueue in remove



On 13/11/19 7:38, Chuhong Yuan wrote:
> The driver forgets to destroy workqueue in remove.
> Add the missed call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Applied for 5.5

Thanks,
 Enric

> ---
>  drivers/platform/chrome/cros_usbpd_logger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
> index 2430e8b82810..374cdd1e868a 100644
> --- a/drivers/platform/chrome/cros_usbpd_logger.c
> +++ b/drivers/platform/chrome/cros_usbpd_logger.c
> @@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
>  	struct logger_data *logger = platform_get_drvdata(pd);
>  
>  	cancel_delayed_work_sync(&logger->log_work);
> +	destroy_workqueue(logger->log_workqueue);
>  
>  	return 0;
>  }
>