linux-kernel - Re: [PATCH v2 2/2] arm64: dts: freescale: add initial support for Google i.MX 8MQ Phanbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5ByMkp1i=rMScgadT9_ucnsxqn_pnSP4bmLUPnxPdYHvw@mail.gmail.com>
Date:   Thu, 21 Nov 2019 15:22:36 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Marco Antonio Franchi <marco.franchi@....com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "marcofrk@...il.com" <marcofrk@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "atv@...gle.com" <atv@...gle.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: add initial support for
 Google i.MX 8MQ Phanbell

Hi Marco,

On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
<marco.franchi@....com> wrote:
>
> This patch adds the device tree to support Google Coral Edge TPU,
> historicaly named as fsl-imx8mq-phanbell, a computer on module
> which can be used for AI/ML propose.
>
> It introduces a minimal enablement support for this module and
> was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell

Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
they are different boards.

> +       memory@...00000 {
> +               device_type = "memory";
> +               reg = <0x00000000 0x40000000 0 0xc0000000>;

The memory size here does not match with the one used in the Google repo.

With these changes you can add:

Reviewed-by: Fabio Estevam <festevam@...il.com>