linux-kernel - Re: [PATCH 4.19 233/422] netfilter: nf_tables: avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121203513.GJ20235@breakpoint.cc>
Date:   Thu, 21 Nov 2019 21:35:13 +0100
From:   Florian Westphal <fw@...len.de>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Florian Westphal <fw@...len.de>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 233/422] netfilter: nf_tables: avoid BUG_ON usage

Pavel Machek <pavel@...x.de> wrote:
> This goes from "kill kernel with backtrace" to "silently return
> failure". Should WARN_ON() be preserved here?

No need.  The error would propagate back to userspace via nfnetlink.

So it would be 'running this command fails with error x' vs.
'running this command makes kernel crash'.

That being said, I did not observe this BUG from triggering, ever.
I only removed it because I did not see any reason for it.