linux-kernel - Re: [PATCH net] udp: drop skb extensions before marking skb stateless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1.1911211544070.26591@winds.org>
Date:   Thu, 21 Nov 2019 15:46:05 -0500 (EST)
From:   Byron Stanoszek <gandalf@...ds.org>
To:     Florian Westphal <fw@...len.de>
cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] udp: drop skb extensions before marking skb
 stateless

On Thu, 21 Nov 2019, Florian Westphal wrote:

> Once udp stack has set the UDP_SKB_IS_STATELESS flag, later skb free
> assumes all skb head state has been dropped already.
>
> This will leak the extension memory in case the skb has extensions other
> than the ipsec secpath, e.g. bridge nf data.
>
> To fix this, set the UDP_SKB_IS_STATELESS flag only if we don't have
> extensions or if the extension space can be free'd.
>
> Fixes: 895b5c9f206eb7d25dc1360a ("netfilter: drop bridge nf reset from nf_reset")
> Cc: Paolo Abeni <pabeni@...hat.com>
> Reported-by: Byron Stanoszek <gandalf@...ds.org>
> Signed-off-by: Florian Westphal <fw@...len.de>

I confirm that this fixes the memory leak on my systems. Thank you for the fast
turnaround.

Regards,
  -Byron