linux-kernel - Re: [PATCH v8 4/6] pwm: sun4i: Always calculate params when applying new parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121211142.kuhcxpxudt3tod4p@pengutronix.de>
Date:   Thu, 21 Nov 2019 22:11:43 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Clément Péron <peron.clem@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Philipp Zabel <pza@...gutronix.de>, linux-pwm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com, kernel@...gutronix.de
Subject: Re: [PATCH v8 4/6] pwm: sun4i: Always calculate params when applying
 new parameters

On Thu, Nov 21, 2019 at 08:59:00PM +0100, Clément Péron wrote:
> Bypass mode will require to be re-calculated when the pwm state
> is changed.
> 
> Remove the condition so pwm_sun4i_calculate is always called.
> 
> Signed-off-by: Clément Péron <peron.clem@...il.com>

When applying this patch and looking at it using git show -b it is
obvious the patch does exactly what is promised here. (Apart from the
introduced empty line in the last hunk which is ok in my book.)

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |