linux-kernel - RE: [PATCH v2 05/13] exfat: add file operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <010201d5a01d$48493270$d8db9750$@samsung.com>
Date:   Thu, 21 Nov 2019 12:39:30 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     'Valdis Klētnieks' <valdis.kletnieks@...edu>
Cc:     "'Nikolay Borisov'" <nborisov@...e.com>,
        <gregkh@...uxfoundation.org>, <hch@....de>, <linkinjeon@...il.com>,
        <Markus.Elfring@....de>, <sj1557.seo@...sung.com>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v2 05/13] exfat: add file operations

> 
> On Thu, 21 Nov 2019 10:42:13 +0900, "Namjae Jeon" said:
> 
> > > > +		if (clu.flags == 0x03) {
> > >
> > > That 0x03 is magic constant, better define actual flags and check
> > > clu.flag == (FLAG1|FLAG2)
> > Okay, Will fix it on v4.
> 
> Make sure you catch all the cases.  I seem to remember a lot of 0x01's
> in the code as well....
Yes, I know.
Thanks!