linux-kernel - Re: [PATCH v5 15/27] nfs: get rid of ->set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1911211651220.3625@namei.org>
Date:   Thu, 21 Nov 2019 16:52:40 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     Scott Mayhew <smayhew@...hat.com>
cc:     anna.schumaker@...app.com, trond.myklebust@...merspace.com,
        David Howells <dhowells@...hat.com>, viro@...iv.linux.org.uk,
        linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH v5 15/27] nfs: get rid of ->set_security()

On Wed, 20 Nov 2019, Scott Mayhew wrote:

> From: Al Viro <viro@...iv.linux.org.uk>
> 
> it's always either nfs_set_sb_security() or nfs_clone_sb_security(),
> the choice being controlled by mount_info->cloned != NULL.  No need
> to add methods, especially when both instances live right next to
> the caller and are never accessed anywhere else.
> 
> Reviewed-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Please ensure that any changes relating to the LSM API are cc'd to the 
linux-security-module list.


-- 
James Morris
<jmorris@...ei.org>