linux-kernel - Re: [PATCH v3] arm64: zynqmp: Add ZynqMP SDHCI compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c6936aa-0760-2f35-3996-4992651f4ed7@monstr.eu>
Date:   Thu, 21 Nov 2019 09:40:30 +0100
From:   Michal Simek <monstr@...str.eu>
To:     Manish Narani <manish.narani@...inx.com>, robh+dt@...nel.org,
        mark.rutland@....com, michal.simek@...inx.com, arnd@...db.de,
        horms+renesas@...ge.net.au, khilman@...libre.com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, git@...inx.com
Subject: Re: [PATCH v3] arm64: zynqmp: Add ZynqMP SDHCI compatible string

On 21. 11. 19 9:34, Michal Simek wrote:
> On 17. 10. 19 9:28, Manish Narani wrote:
>> Add the new compatible string for ZynqMP SD Host Controller for its use
>> in the Arasan SDHCI driver for some of the ZynqMP specific operations.
>> Add required properties for the same.
>>
>> Signed-off-by: Manish Narani <manish.narani@...inx.com>
>> ---
>> This patch depends on the below series of patches:
>> https://lkml.org/lkml/2019/10/17/37
>>
>> Changes in v2:
>> 	- Added clock-names for SD card clocks for getting clocks in the driver
>>
>> Changes in v3:
>> 	- Reverted "Added clock-names for SD card clocks for getting clocks in the driver"
>> ---
>>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index 9aa67340a4d8..c7b8c3c28aa7 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -494,20 +494,26 @@
>>  
>>  		sdhci0: mmc@...60000 {
>>  			compatible = "arasan,sdhci-8.9a";
>> +			compatible = "xlnx,zynqmp-8.9a", "arasan,sdhci-8.9a";
>>  			status = "disabled";
>>  			interrupt-parent = <&gic>;
>>  			interrupts = <0 48 4>;
>>  			reg = <0x0 0xff160000 0x0 0x1000>;
>>  			clock-names = "clk_xin", "clk_ahb";
>> +			#clock-cells = <1>;
>> +			clock-output-names = "clk_out_sd0", "clk_in_sd0";
>>  		};
>>  
>>  		sdhci1: mmc@...70000 {
>>  			compatible = "arasan,sdhci-8.9a";
>> +			compatible = "xlnx,zynqmp-8.9a", "arasan,sdhci-8.9a";
>>  			status = "disabled";
>>  			interrupt-parent = <&gic>;
>>  			interrupts = <0 49 4>;
>>  			reg = <0x0 0xff170000 0x0 0x1000>;
>>  			clock-names = "clk_xin", "clk_ahb";
>> +			#clock-cells = <1>;
>> +			clock-output-names = "clk_out_sd1", "clk_in_sd1";
>>  		};
>>  
>>  		smmu: smmu@...00000 {
>>
> 
> Patches have been applied
> https://lkml.org/lkml/2019/11/20/366
> 
> That's why I have applied this one to my tree.

Sorry for confusion. I removed this patch. There are two lines with
compatible property which is wrong. Please send v4.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs




Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)