linux-kernel - RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR13MB336857C8AAC4CD3EB48942BF8C4E0@CH2PR13MB3368.namprd13.prod.outlook.com>
Date:   Thu, 21 Nov 2019 08:55:32 +0000
From:   Yash Shah <yash.shah@...ive.com>
To:     Yash Shah <yash.shah@...ive.com>, Marc Zyngier <maz@...nel.org>
CC:     "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "atish.patra@....com" <atish.patra@....com>,
        Sachin Ghadi <sachin.ghadi@...ive.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "palmer@...belt.com" <palmer@...belt.com>,
        Sagar Kadam <sagar.kadam@...ive.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "Paul Walmsley ( Sifive)" <paul.walmsley@...ive.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "bmeng.cn@...il.com" <bmeng.cn@...il.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell



> -----Original Message-----
> From: linux-riscv <linux-riscv-bounces@...ts.infradead.org> On Behalf Of
> Yash Shah
> Sent: 21 November 2019 14:06
> To: Marc Zyngier <maz@...nel.org>
> Cc: mark.rutland@....com; devicetree@...r.kernel.org;
> aou@...s.berkeley.edu; jason@...edaemon.net; atish.patra@....com;
> Sachin Ghadi <sachin.ghadi@...ive.com>; linus.walleij@...aro.org; linux-
> kernel@...r.kernel.org; bgolaszewski@...libre.com; robh+dt@...nel.org;
> palmer@...belt.com; Sagar Kadam <sagar.kadam@...ive.com>; linux-
> gpio@...r.kernel.org; Paul Walmsley ( Sifive) <paul.walmsley@...ive.com>;
> tglx@...utronix.de; bmeng.cn@...il.com; linux-riscv@...ts.infradead.org
> Subject: RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell
> 
> > -----Original Message-----
> > From: Marc Zyngier <maz@...nel.org>
> > Sent: 20 November 2019 16:09
> > To: Yash Shah <yash.shah@...ive.com>
> > Cc: linus.walleij@...aro.org; bgolaszewski@...libre.com;
> > robh+dt@...nel.org; mark.rutland@....com; palmer@...belt.com; Paul
> > Walmsley ( Sifive) <paul.walmsley@...ive.com>; aou@...s.berkeley.edu;
> > tglx@...utronix.de; jason@...edaemon.net; bmeng.cn@...il.com;
> > atish.patra@....com; Sagar Kadam <sagar.kadam@...ive.com>; linux-
> > gpio@...r.kernel.org; devicetree@...r.kernel.org; linux-
> > riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Sachin Ghadi
> > <sachin.ghadi@...ive.com>
> > Subject: Re: [PATCH v2 1/5] genirq: introduce
> > irq_domain_translate_onecell
> >
> > On 2019-11-20 06:59, Yash Shah wrote:
> > > Add a new function irq_domain_translate_onecell() that is to be used
> > > as the translate function in struct irq_domain_ops for the v2 IRQ API.
> > >
> > > Signed-off-by: Yash Shah <yash.shah@...ive.com>
> [...]
> > >
> > >  /**
> > > + * irq_domain_translate_onecell() - Generic translate for direct
> > > + one
> > > cell
> > > + * bindings
> > > + *
> > > + * Device Tree IRQ specifier translation function which works with
> > > one cell
> >
> > nit: the whole point of the 'new' translate function is that they are
> > firmware-agnostic. Just drop the DT reference here.
> 
> Ok sure.
> 
> >
> > > + * bindings where the cell values map directly to the hwirq number.
> > > + */
> > > +int irq_domain_translate_onecell(struct irq_domain *d,
> > > +				 struct irq_fwspec *fwspec,
> > > +				 unsigned long *out_hwirq,
> > > +				 unsigned int *out_type)
> > > +{
> > > +	if (WARN_ON(fwspec->param_count < 1))
> > > +		return -EINVAL;
> > > +	*out_hwirq = fwspec->param[0];
> > > +	*out_type = IRQ_TYPE_NONE;
> > > +	return 0;
> > > +}
> > > +EXPORT_SYMBOL_GPL(irq_domain_translate_onecell);
> > > +
> > > +/**
> > >   * irq_domain_translate_twocell() - Generic translate for direct
> > > two cell
> > >   * bindings
> > >   *
> >
> > Can you please also update (potentially in a separate patch) the
> > potential users of this? I mentioned the nvic driver last time...
> >
> 
> Ok, I will separate out this patch from the patchset and send it individually
> along with potential users of it.
> Thanks for your comments

I am sorry, I think I misunderstood you.
You want me to send a new separate patch in which the potential users will be updated to this new function.
Hope I got it right?

- Yash