linux-kernel - Re: [PATCH v4 03/13] exfat: add inode operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Nov 2019 11:40:28 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        Daniel Wagner <dwagner@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nikolay Borisov <nborisov@...e.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Valdis Klētnieks <valdis.kletnieks@...edu>,
        linkinjeon@...il.com
Subject: Re: [PATCH v4 03/13] exfat: add inode operations

…
> +++ b/fs/exfat/inode.c
…
> +static int exfat_bmap(struct inode *inode, sector_t sector, sector_t *phys,
> +		unsigned long *mapped_blocks, int *create)
> +{
…
> +	err = exfat_map_cluster(inode, clu_offset, &cluster,
> +		*create & BMAP_ADD_CLUSTER);

I find an other indentation more appropriate.
Please align the last parameter below (or besides) the opening parenthesis.


> +	if (err) {
> +		if (err != -ENOSPC)
> +			return -EIO;
> +		return err;
> +	}

Can such source code become more succinct?

+	if (err)
+		return err != -ENOSPC ? -EIO : err;

Regards,
Markus