linux-kernel - Re: [PATCH] pinctrl: Fix Kconfig indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPc6C5WE0mV4=YRGBkKxLb_CWYKGAK=v43NjJW8MY8FMEQ@mail.gmail.com>
Date:   Thu, 21 Nov 2019 09:27:24 +0800
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dong Aisheng <aisheng.dong@....com>,
        Fabio Estevam <festevam@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stefan Agner <stefan@...er.ch>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-gpio@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-arm-msm@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] pinctrl: Fix Kconfig indentation

On Wed, 20 Nov 2019 at 22:15, Ahmad Fatoum <a.fatoum@...gutronix.de> wrote:
>
> Hello Krzysztof,
>
> On 11/20/19 2:40 PM, Krzysztof Kozlowski wrote:
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> >       $ sed -e 's/^        /\t/' -i */Kconfig
>
> >  config PINCTRL_ARTPEC6
> > -        bool "Axis ARTPEC-6 pin controller driver"
> > +     bool "Axis ARTPEC-6 pin controller driver"
>
> Here you replace spaces for tabs before the prompt type.
>
> >  config PINCTRL_SM8150
> >         tristate "Qualcomm Technologies Inc SM8150 pin controller driver"
>
> Here you leave the spaces before intact.
>
> Intentional?

No, not intentional. Thanks for pointing it out. I made the sed
patterns precise - 8 spaces -> tab, and there you have 7 spaces
(ugh!). I'll send a follow up.

Best regards,
Krzysztof