linux-kernel - Re: [PATCH v2 1/2] pinctrl: rza1: remove unnecessary static inline function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbDz6HSZZPFB4cHMO=C9WQ7O_UQJAgO_2zyALEYzEEVsA@mail.gmail.com>
Date:   Thu, 21 Nov 2019 14:33:28 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] pinctrl: rza1: remove unnecessary static inline function

On Wed, Nov 13, 2019 at 8:10 AM Matti Vaittinen
<matti.vaittinen@...rohmeurope.com> wrote:

> Having static inline oneliner does not benefit too mucg when it is
> only called from another oneliner function. Remove some of the
> 'onion'. This simplifies also the coming usage of the gpiolib
> defines. We can do conversion from chip bits to gpiolib direction
> defines as last step in the get_direction callback. Drivers can
> use chip specific values in driver internal functions and do
> conversion only once.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>
> Changes since v1: Subject fixed as pointed out by Geert.

Patch applied.

Yours,
Linus Walleij