linux-kernel - Re: [PATCH v3] usb: xhci: only set D3hot for pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 21 Nov 2019 01:53:42 +0000
From:   Henry Lin <henryl@...dia.com>
To:     Jack Pham <jackp@...eaurora.org>
CC:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] usb: xhci: only set D3hot for pci device

>> @@ -770,7 +770,7 @@ static void xhci_stop(struct usb_hcd *hcd)
>>   *
>>   * This will only ever be called with the main usb_hcd (the USB3 roothub).
>>   */
>> -static void xhci_shutdown(struct usb_hcd *hcd)
>> +void xhci_shutdown(struct usb_hcd *hcd)
>>  {
>>       struct xhci_hcd *xhci = hcd_to_xhci(hcd);
>>
>> @@ -789,10 +789,6 @@ static void xhci_shutdown(struct usb_hcd *hcd)
>>       xhci_dbg_trace(xhci, trace_xhci_dbg_init,
>>                       "xhci_shutdown completed - status = %x",
>>                       readl(&xhci->op_regs->status));
>> -
>> -     /* Yet another workaround for spurious wakeups at shutdown with HSW */
>> -     if (xhci->quirks & XHCI_SPURIOUS_WAKEUP)
>> -             pci_set_power_state(to_pci_dev(hcd->self.sysdev), PCI_D3hot);
>>  }

>Shouldn't this function also now need to be EXPORTed?
Yes. I will add EXPORT_SYMBOL_GPL() for it.