linux-kernel - Re: [Y2038] [PATCH 02/23] y2038: add __kernel_old_timespec and __kernel_old_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Nov 2019 15:17:36 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     y2038 Mailman List <y2038@...ts.linaro.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        linux-arch <linux-arch@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [Y2038] [PATCH 02/23] y2038: add __kernel_old_timespec and __kernel_old_time_t

On Wed, Nov 20, 2019 at 11:30 PM Ben Hutchings
<ben.hutchings@...ethink.co.uk> wrote:
>
> On Fri, 2019-11-08 at 22:07 +0100, Arnd Bergmann wrote:
> > The 'struct timespec' definition can no longer be part of the uapi headers
> > because it conflicts with a a now incompatible libc definition. Also,
> > we really want to remove it in order to prevent new uses from creeping in.
> >
> > The same namespace conflict exists with time_t, which should also be
> > removed. __kernel_time_t could be used safely, but adding 'old' in the
> > name makes it clearer that this should not be used for new interfaces.
> >
> > Add a replacement __kernel_old_timespec structure and __kernel_old_time_t
> > along the lines of __kernel_old_timeval.
> [...]
> > --- a/include/uapi/linux/time_types.h
> > +++ b/include/uapi/linux/time_types.h
> > @@ -28,6 +28,11 @@ struct __kernel_old_timeval {
> >  };
> >  #endif
> >
> > +struct __kernel_old_timespec {
> > +     __kernel_time_t tv_sec;                 /* seconds */
>
> Should this be __kernel_old_time_t for consistency?

Yes. I had already noticed this and changed it in the current version
of "y2038: uapi: change __kernel_time_t to __kernel_old_time_t".

      Arnd