linux-kernel - Re: [PATCH V2 1/2] dt-bindings: syscon: Add syscon-names to refer to syscon easily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1vuPWZYpMB9OGdLaCmbC6A0+5ecjKmdMqFUjpPmwp+tg@mail.gmail.com>
Date:   Thu, 21 Nov 2019 15:59:34 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Orson Zhai <orson.zhai@...soc.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        DTML <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kevin.tang@...soc.com, baolin.wang@...soc.com,
        Chunyan Zhang <chunyan.zhang@...soc.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: syscon: Add syscon-names to refer to
 syscon easily

On Wed, Nov 20, 2019 at 4:44 PM Orson Zhai <orson.zhai@...soc.com> wrote:
>
> +
> +Optional property:
> +- #.*-cells: Represents the number of arguments in single phandle in syscons
> +  list. ".*" is vendor specific. If this property is not set, default value
> +  will be 0.
> +
> +Examples:
> +
> +apb_regs: syscon@...08000 {
> +       compatible = "sprd,apb-glb", "syscon";
> +       reg = <0x20008000 0x100>;
> +};
> +
> +aon_regs: syscon@...08000 {
> +       compatible = "sprd,aon-glb", "syscon";
> +       reg = <0x40008000 0x100>;
> +};
> +
> +display@...00000 {
> +       ...
> +       #syscon-disp-cells = <2>;
> +       syscons = <&ap_apb_regs 0x4 0xf00>, <&aon_regs 0x8 0x7>;
> +       syscon-names = "enable", "power";
> +};


Hi Orson,

With the changes from the syscon nodes removed, it looks better
already, but I'd also like to not see the #.*-cells mentioned at
all, as there is not really a way to parse this automatically, or
make sense of the data without already knowing how many cells
there are.

       Arnd