linux-kernel - RE: [PATCH] misc: xilinx_sdfec: add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR02MB63591D25827E2A88BE9AE897CB4E0@CH2PR02MB6359.namprd02.prod.outlook.com>
Date:   Thu, 21 Nov 2019 15:40:09 +0000
From:   Dragan Cvetic <draganc@...inx.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Derek Kiernan <dkiernan@...inx.com>
Subject: RE: [PATCH] misc: xilinx_sdfec: add missing __user annotation

Hi Luc,

Find my comments below

> -----Original Message-----
> From: Luc Van Oostenryck [mailto:luc.vanoostenryck@...il.com]
> Sent: Thursday 21 November 2019 12:08
> To: linux-kernel@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org; Luc Van Oostenryck <luc.vanoostenryck@...il.com>; Derek Kiernan
> <dkiernan@...inx.com>; Dragan Cvetic <draganc@...inx.com>
> Subject: [PATCH] misc: xilinx_sdfec: add missing __user annotation
> 
> The second arg of xsdfec_set_order() is a 'void __user *'
> and this pointer is then used in get_user() which expect
> a __user pointer.
> 
> But get_user() can't be used with a void pointer, it a
> pointer to the effective type. This is done here by casting
> the argument to a pointer to the effective type but the
> __user is missing in the cast.
> 
> Fix this by adding the missing __user in the cast.
> 
> CC: Derek Kiernan <derek.kiernan@...inx.com>
> CC: Dragan Cvetic <dragan.cvetic@...inx.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> ---
>  drivers/misc/xilinx_sdfec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 11835969e982..f05e1b4c2826 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -733,7 +733,7 @@ static int xsdfec_set_order(struct xsdfec_dev *xsdfec, void __user *arg)
>  	enum xsdfec_order order;
>  	int err;
> 
> -	err = get_user(order, (enum xsdfec_order *)arg);
> +	err = get_user(order, (enum xsdfec_order __user *)arg);
>  	if (err)
>  		return -EFAULT;
> 
> --
> 2.24.0


Acked-by: Dragan Cvetic <dragan.cvetic@...inx.com>