linux-kernel - Re: [PATCH] drivers: usb: consolidate USB vendor IDs in one include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121163309.GA651886@kroah.com>
Date:   Thu, 21 Nov 2019 17:33:09 +0100
From:   Greg KH <greg@...ah.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, jikos@...nel.org,
        benjamin.tissoires@...hat.com, dmitry.torokhov@...il.com,
        Jes.Sorensen@...il.com, kvalo@...eaurora.org, johan@...nel.org,
        linux-input@...r.kernel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] drivers: usb: consolidate USB vendor IDs in one include
 file

On Thu, Nov 21, 2019 at 05:17:42PM +0100, Enrico Weigelt, metux IT consult wrote:
> Instead of redefining usb vendor IDs in several places, consolidate
> into one include file: include/linux/usb/usb_ids.h

No, please no.

There's a specific reason we do not have this, unlike other operating
systems.  It's because merges are a pain, and touching the "big one
file" ends up rebuilding too many things.

Read the top of the pci-ids.h file for why I do not want to see us do
this for any other type of id.  It's best to leave them where they are
used, right in the driver itself.

thanks,

greg k-h