lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 21 Nov 2019 17:42:39 +0100
From:   Greg KH <greg@...ah.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, balbi@...nel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] drivers: usb: Kconfig: cleanup indentions

On Thu, Nov 21, 2019 at 04:14:08PM +0100, Enrico Weigelt, metux IT consult wrote:
> Make the code look a little bit nicer.

That is really vague.

What exactly are you doing here, and why?

> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/usb/dwc3/Kconfig | 30 +++++++++++++++---------------
>  drivers/usb/misc/Kconfig | 24 ++++++++++++------------
>  2 files changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 556a876c7896..7695841a108f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -97,24 +97,24 @@ config USB_DWC3_KEYSTONE
>  	  Say 'Y' or 'M' here if you have one such device
>  
>  config USB_DWC3_MESON_G12A
> -       tristate "Amlogic Meson G12A Platforms"
> -       depends on OF && COMMON_CLK
> -       depends on ARCH_MESON || COMPILE_TEST
> -       default USB_DWC3
> -       select USB_ROLE_SWITCH
> +	tristate "Amlogic Meson G12A Platforms"
> +	depends on OF && COMMON_CLK
> +	depends on ARCH_MESON || COMPILE_TEST
> +	default USB_DWC3
> +	select USB_ROLE_SWITCH
>  	select REGMAP_MMIO

I think this change is already in my tree, right?  Please don't
duplicate work that others already did.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ