linux-kernel - Re: [PATCH 11/12] crypto: caam - add crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB348579F11E5BF69DBACF756A984E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Date:   Thu, 21 Nov 2019 16:53:54 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Tom Lendacky <thomas.lendacky@....com>,
        Gary Hook <gary.hook@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 11/12] crypto: caam - add crypto_engine support for RSA
 algorithms

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:
> @@ -311,14 +329,16 @@ static struct rsa_edesc *rsa_edesc_alloc(struct akcipher_request *req,
>  	edesc->src_nents = src_nents;
>  	edesc->dst_nents = dst_nents;
>  
> +	edesc->jrentry.base = &req->base;
> +
> +	req_ctx->edesc = edesc;
> +
>  	if (!sec4_sg_bytes)
>  		return edesc;
>  
>  	edesc->mapped_src_nents = mapped_src_nents;
>  	edesc->mapped_dst_nents = mapped_dst_nents;
>  
> -	edesc->jrentry.base = &req->base;
> -
This is a bug fix - edesc->jrentry.base must be set earlier,
before having the chance to return from the function (in case no S/G table
needs to be generated).

It should be squashed into
[PATCH 07/12] crypto: caam - refactor caam_jr_enqueue

Horia