linux-kernel - Re: [PATCH v10 6/6] x86/split_lock: Enable split lock detection by kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121171401.GE12042@gmail.com>
Date:   Thu, 21 Nov 2019 18:14:01 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        H Peter Anvin <hpa@...or.com>,
        Tony Luck <tony.luck@...el.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v10 6/6] x86/split_lock: Enable split lock detection by
 kernel parameter


* Fenghua Yu <fenghua.yu@...el.com> wrote:

> > This feature MUST be default enabled, otherwise everything will 
> > be/remain broken and we'll end up in the situation where you can't 
> > use it even if you wanted to.
> 
> The usage scope of this patch set is largely reduced to only real time. 
> The long split lock processing time (>1000 cycles) cannot be tolerated 
> by real time.
> 
> Real time customers do want to use this feature to detect the fatal 
> split lock error. They don't want any split lock issue from BIOS/EFI/ 
> firmware/kerne/drivers/user apps.
> 
> Real time can enable the feature (set bit 29 in TEST_CTRL MSR) in BIOS 
> and don't need OS to enable it. But, #AC handler cannot handle split 
> lock in the kernel and will return to the faulting instruction and 
> re-enter #AC. So current #AC handler doesn't provide useful information 
> for the customers. That's why we add the new #AC handler in this patch 
> set.

Immaterial - for this feature to be useful it must be default-enabled, 
with reasonable quirk knobs offered to people who happen to be bitten by 
such bugs and cannot fix the software.

But default-enabled is a must-have, as Peter said.

Thanks,

	Ingo