linux-kernel - Re: [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bAm0r8zLMz_gdq30zF8io5RzVnbXFSV9NkyT_uUxKJwLA@mail.gmail.com>
Date:   Thu, 21 Nov 2019 19:39:22 -0500
From:   Pavel Tatashin <pasha.tatashin@...een.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>, stefan@...er.ch,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Will Deacon <will@...nel.org>, boris.ostrovsky@...cle.com,
        Sasha Levin <sashal@...nel.org>, sstabellini@...nel.org,
        James Morris <jmorris@...ei.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        xen-devel@...ts.xenproject.org,
        Vladimir Murzin <vladimir.murzin@....com>,
        Marc Zyngier <marc.zyngier@....com>, alexios.zavras@...el.com,
        Thomas Gleixner <tglx@...utronix.de>, allison@...utok.net,
        jgross@...e.com, steve.capper@....com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        James Morse <james.morse@....com>, info@...ux.net
Subject: Re: [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call

> > That may be, but be very careful that you only use them in ARMv7-only
> > code.  Using them elsewhere is unsafe as the domain register is used
> > for other purposes, and merely blatting over it (as your
> > uaccess_enable and uaccess_disable functions do) is unsafe.
>
> In fact, I'll turn that into a bit more than a suggestion.  I'll make
> it a NAK on adding them to 32-bit ARM.
>

That's fine, and I also did not want to change ARM 32-bit. But, do you
have a suggestion how differentiate between arm64 and arm in
include/xen/arm/hypercall.h without ugly ifdefs?

Thank you,
Pasha