linux-kernel - Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc>
Date:   Fri, 22 Nov 2019 14:08:08 +0100
From:   Michael Walle <michael@...le.cc>
To:     linus.walleij@...aro.org
Cc:     bgolaszewski@...libre.com, devicetree@...r.kernel.org,
        hui.song_1@....com, leoyang.li@....com,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        robh+dt@...nel.org, shawnguo@...nel.org
Subject: Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode
 bug fixs.

>> From: Song Hui <hui.song_1@....com>
>> 
>> On these boards, the irq_set_type must point one valid function 
>> pointer
>> that can correctly set both edge and falling edge.
>> 
>> Signed-off-by: Song Hui <hui.song_1@....com>
> 
> Patch applied!
> 
> Yours,
> Linus Walleij

mhh.. this bug should already be fixed in a better way with [1]:
   gpio: mpc8xxx: Don't overwrite default irq_set_type callback

-michael

[1] 
https://lore.kernel.org/lkml/CACRpkdZ5eWHEV-oN77QxH9X4DZRUB3zM=gP=+rM=ZLAX6Wxw9w@mail.gmail.com/