linux-kernel - Re: [Linux-stm32] [PATCH v2 1/1] drivers: watchdog: stm32_iwdg: set WDOG_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70c319bd-866c-5305-e535-ead663652c5f@st.com>
Date:   Fri, 22 Nov 2019 13:15:07 +0000
From:   Christophe ROULLIER <christophe.roullier@...com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [Linux-stm32] [PATCH v2 1/1] drivers: watchdog: stm32_iwdg: set
 WDOG_HW_RUNNING at probe


On 11/22/19 11:28 AM, Ahmad Fatoum wrote:
> Hello Christophe,
>
> On 11/22/19 9:24 AM, Christophe Roullier wrote:
>> +	/*
>> +	 * In case of CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED is set
>> +	 * (Means U-Boot/bootloaders leaves the watchdog running)
>> +	 * When we get here we should make a decision to prevent
>> +	 * any side effects before user space daemon will take care of it.
>> +	 * The best option, taking into consideration that there is no
>> +	 * way to read values back from hardware, is to enforce watchdog
>> +	 * being run with deterministic values.
> What about the "ONF: Watchdog enable status bit" in the IWDG_SR register?
>
> Cheers
> Ahmad
>
Hi,

Thanks Ahmad for your feedback, it is a mistake in our ref manual. This 
bit is not present

in our iwdg IP, we will update our documentation accordingly.

Regards,

Christophe